search

gardener / machine-controller-manager-provider-gcp

Gardener machine controller manager provider for GCP
Apache License 2.0
3 stars 29 forks source link

remove disk type validation #108

Closed kon-angelo closed 7 months ago

kon-angelo commented 7 months ago

What this PR does / why we need it: Removes strict disk type validation. The main reason is to support https://github.com/gardener/gardener-extension-provider-gcp/issues/702. As providers add more disk types the validations need to be adapted.

The PR could go either way, of adding the check for the new type or removing the current check and I was in favor of the later approach.

Which issue(s) this PR fixes: Fixes #

Special notes for your reviewer:

Release note:

Remove strict validation about disk types
rishabh-11 commented 7 months ago

If we remove the validation and the disk type does not exist, it will be known only during the VM creation and not before that. Is that fine for the customer?

kon-angelo commented 7 months ago

From gardener perspective there is an additional validation done from cloudprofile. So the user will discover it about the same time. But by removing this validation, next time I need to add a disk type, I only need to do it on cloudprofile level.

For a standalone MCM use, the question is if these disks are different than say vm types, which we accept as input, but do not validate against.