search

gardener / machine-controller-manager-provider-gcp

Gardener machine controller manager provider for GCP
Apache License 2.0
3 stars 27 forks source link

Support Gardener credentials data keys #11

Closed rfranzke closed 3 years ago

rfranzke commented 3 years ago

/area open-source usability /kind enhancement /priority normal /platform gcp

What this PR does / why we need it: All the secret keys used by Gardener are now also allowed as alternatives for this machine-controller-manager plugin. This helps to not make mappings for the data keys.

Special notes for your reviewer: ℹ️ Similar improvement for in-tree driver: https://github.com/gardener/machine-controller-manager/pull/578/commits/0e41070979b21dae4e27fe6504bdc99f651ec3b7 (https://github.com/gardener/machine-controller-manager/pull/578)

Release note:

The machine class secret does now also accept the data key `serviceaccount.json` as alternatives for today's key.
rfranzke commented 3 years ago

/assign @hardikdr @prashanth26 @amshuman-kr @AxiomSamarth