search

gardener / machine-controller-manager-provider-gcp

Gardener machine controller manager provider for GCP
Apache License 2.0
3 stars 29 forks source link

ListMachines method errors out when the instances are not found #29

Closed AxiomSamarth closed 2 years ago

AxiomSamarth commented 2 years ago

What happened: ListMachines method errors out when there are no instances found in a project & zone. Thus resulting in false/unwanted errors in the orphan collection. Even though nothing is breaking, the dump of false errors in the logs makes it difficult to debug other issues.

What you expected to happen: When there are no instances found in a project & zone, ListMachines method should return an empty MachineList

How to reproduce it (as minimally and precisely as possible):

  1. Create a cluster with multi zone worker pool with minimum of 1 machine.
  2. Observe the logs to witness the above error where the orphan collection posts error messages for machineClasses whose machines objects are not present.

Anything else we need to know:

Environment:

rishabh-11 commented 2 years ago

/close as this issue was observed when mcm-provider-gcp used google.golang.org/api:v0.4.0. The current release uses google.golang.org/api:v0.30.0 and with that this issue does not happen anymore.