search

gardener / machine-controller-manager-provider-gcp

Gardener machine controller manager provider for GCP
Apache License 2.0
3 stars 29 forks source link

Reworks Orphan Collection Deletion #47

Closed Mkmittal closed 2 years ago

Mkmittal commented 2 years ago

What this PR does / why we need it: Reworks probeResources and deletion of Orphan resources. similar to https://github.com/gardener/machine-controller-manager-provider-aws/pull/85 Which issue(s) this PR fixes: Fixes #

Special notes for your reviewer:

Release note:

probeResources() now doesn't try to delete orphan resources but only lists them.
The beforeSuite for IT test now calls for cleanup of orphan resources separately.
The Integration Test, which looks for orphan resources, now doesn't try to delete the orphan resources and just waits for them to be done automatically.
gardener-robot commented 2 years ago

@Mkmittal Thank you for your contribution.

gardener-robot-ci-1 commented 2 years ago

Thank you @Mkmittal for your contribution. Before I can start building your PR, a member of the organization must set the required label(s) {'reviewed/ok-to-test'}. Once started, you can check the build status in the PR checks section below.

gardener-robot commented 2 years ago

@Mkmittal You need rebase this pull request with latest master branch. Please check.