search

gardener / machine-controller-manager-provider-openstack

Out of tree implementation for machine-controller-manager's provider-openstack
Apache License 2.0
4 stars 25 forks source link

Increase openstack poll interval #115

Closed dergeberl closed 7 months ago

dergeberl commented 7 months ago

What this PR does / why we need it:

This PR increase the openstack poll interval from 1 second to 10 seconds. In my opinion there is no need to poll every second. All this tasks need a few second and to reduce the number of API calls against openstack is suggest to set the interval to 10 seconds.

Additionally I switched from the depricated wait.Poll to wait.PollUntilContextTimeout

Which issue(s) this PR fixes: Fixes #

Special notes for your reviewer:

Release note:

Increase openstack poll interval to reduce the number of openstack API calls.
gardener-robot commented 7 months ago

@dergeberl Thank you for your contribution.

gardener-robot-ci-1 commented 7 months ago

Thank you @dergeberl for your contribution. Before I can start building your PR, a member of the organization must set the required label(s) {'reviewed/ok-to-test'}. Once started, you can check the build status in the PR checks section below.

dergeberl commented 7 months ago

@kon-angelo I changed the immediate argument of wait.PollUntilContextTimeout-function to true. Otherwise the tests would need more than 120sec and fail. With immediate on true the first check will be done directly.

kon-angelo commented 7 months ago

/reviewed ok-to-test