search

gardener / machine-controller-manager

Declarative way of managing machines for Kubernetes cluster
Apache License 2.0
256 stars 117 forks source link

Do not set finalizers on MachineSets and MachineDeployments #524

Open mvladev opened 4 years ago

mvladev commented 4 years ago

What happened:

Don't set finalizers on MachineSets and MachineDeployments

What you expected to happen:

Those resources managed by MCM have machine.sapcloud.io/machine-controller-manager finalizer. Such higher level resources should not have that finalizer. Only Machine should have it.

How to reproduce it (as minimally and precisely as possible):

Anything else we need to know:

Environment:

prashanth26 commented 4 years ago

I remember you had opened this PR - https://github.com/gardener/machine-controller-manager/pull/285 long back and it still exists today. And i also remember vaguely having a discussion around this PR. However, i am unable to remember why we didn't discuss on the PR. Let's relook at this.

himanshu-kun commented 1 year ago

We don't know what discussion happened in past , but we think finalizer can be removed because of proper owner references which are already set on the machine and machineSet resources. But it needs more testing to confirm.