Make MaxReplacement configurable

gardener / machine-controller-manager

Declarative way of managing machines for Kubernetes cluster

Apache License 2.0

246 stars 113 forks source link

Make MaxReplacement configurable #688

Open himanshu-kun opened 2 years ago

himanshu-kun commented 2 years ago

How to categorize this issue?

/area quality /kind enhancement /priority 3

What would you like to be added: Machine controller replaces 1 machine per machineDeployment in case of healthTimeout currently as per this PR. But this value should be configurable by user on shoot.Yaml where user can provide maxReplacementsPerZone in worker pool settings.

Why is this needed: For better user control

gardener-robot commented 2 years ago

@himanshu-kun Label area/productivity does not exist.

himanshu-kun commented 2 years ago

cc @unmarshall

rishabh-11 commented 1 year ago

a PR which tried to introduce throttling in Failed machine deletion is https://github.com/gardener/machine-controller-manager/pull/482 It has some ideas regarding making maxReplacement configurable

elankath commented 1 year ago

Grooming

We currently transition un-healthy machines in unknown phase to failed phase by MaxReplacement=1 in every reconcile cycle.
We propose making the MaxReplacements configurable parameter for the machine controller.
- This can be a static or percentage based value. (semantics to be designed later)
We should relook and re-factor the current PermitGiver logic and canMarkMachineFailed logic which does excessive work in the reconcile health check cycle and obviates code clarity.