search

gardener / machine-controller-manager

Declarative way of managing machines for Kubernetes cluster
Apache License 2.0
247 stars 115 forks source link

Zone field in nodeTemplate should be optional #699

Open himanshu-kun opened 2 years ago

himanshu-kun commented 2 years ago

How to categorize this issue?

/area usability /kind enhancement /priority 2

What would you like to be added: Make Zone field a pointer to string with optional tag

Why is this needed: Currently its mandatory to provide zone value to nodeTemplate. However in Azure cloud provider the cluster could be non-zonal because of which this field shouldn't be specified. But we have to specify it a dummy value as of now . Refer PR.

We'll also need to adapt the CA validation of this field in nodeTemplate, and will have to revendor it in different extension providers after this change.

himanshu-kun commented 1 year ago

Post-grooming discussion

It can't be kept empty as seen here https://github.com/gardener/gardener-extension-provider-azure/pull/479 We can make it omitempty and try if it works. Because making it optional means changing the field to pointer which will require changes on each layer , keeping compatibility in mind.