gardener / machine-controller-manager

Declarative way of managing machines for Kubernetes cluster
Apache License 2.0
246 stars 113 forks source link

ProviderID on machine should be same as that on node #708

Open himanshu-kun opened 2 years ago

himanshu-kun commented 2 years ago

How to categorize this issue?

/area quality /kind enhancement /priority 3

What would you like to be added: ProviderID on machine object currently is different than providerID on node in terms of format. We need to follow the same way of providerID as kubernetes nodes. Different providers will have different formats. So the respective changes will have to be made in mcm-providers

Why is this needed:

himanshu-kun commented 1 year ago

Refer https://github.com/gardener/machine-controller-manager/blob/d7e3c5dffeb33abe2c30b435075fb050301da4fa/pkg/util/provider/machinecontroller/machine.go#L386-L391