gardener / machine-controller-manager

Declarative way of managing machines for Kubernetes cluster
Apache License 2.0
257 stars 117 forks source link

[Edge Case] Creation/Health Timeout not respected #811

Open himanshu-kun opened 1 year ago

himanshu-kun commented 1 year ago

How to categorize this issue?

/area quality /kind bug /priority 3

What happened: The creationTimeout / healthTimeout is not respected in the following cases , as per code analysis :

Case 1:

Case 2:

What you expected to happen:

How to reproduce it (as minimally and precisely as possible):

Anything else we need to know?:

Environment:

himanshu-kun commented 1 year ago

Post grooming issue

If node conditions keep flapping , then cloneDirty will become true in every reconcile, so timeout checking is always skipped.

should be dealt in controller runtime refactor.