search

gardener / machine-controller-manager

Declarative way of managing machines for Kubernetes cluster
Apache License 2.0
256 stars 117 forks source link

Support checking GKE version schema #882

Closed lookuptable closed 9 months ago

lookuptable commented 9 months ago

What this PR does / why we need it:

The version format of GKE clusters is $K8S_VERSION-gke.$INTERNAL_NUMBER (e.g., 1.27.9-gke.300). This format is not fully compliant to the SEMVER spec and causes this library to mistakenly recognize, for example, a 1.27.9-gke.300 cluster to be older than 1.21. This is a known issue (e.g., https://github.com/helm/helm/issues/3810), and this change updates the version constraint to properly support GKE versions.

Which issue(s) this PR fixes: N/A

Special notes for your reviewer: N/A

Release note:

NONE

gardener-robot commented 9 months ago

@lookuptable Thank you for your contribution.

gardener-robot-ci-3 commented 9 months ago

Thank you @lookuptable for your contribution. Before I can start building your PR, a member of the organization must set the required label(s) {'reviewed/ok-to-test'}. Once started, you can check the build status in the PR checks section below.

CLAassistant commented 9 months ago

CLA assistant check
All committers have signed the CLA.

sssash18 commented 9 months ago

/lgtm