gardener / machine-controller-manager

Declarative way of managing machines for Kubernetes cluster
Apache License 2.0
256 stars 117 forks source link

Nil panic in MCM 0.51.0 relese, updateNodeToMachine #892

Closed elankath closed 9 months ago

elankath commented 9 months ago

How to categorize this issue?

/area quality /kind bug /priority 1

What happened:

MC's updateNodeToMachine when unable to find the associated Machine obj for a given node erroneously attempts to print the nil machine objects name. This causes Integration Test failures.

    machine, err := c.getMachineFromNode(node.Name)
    if err != nil {
        klog.Errorf("Unable to handle update event for node %s, couldn't fetch machine %s, Error: %s", machine.Name, err)
        return
    }

What you expected to happen:

No nil access is made.

How to reproduce it (as minimally and precisely as possible): Run the Integration Tests for any provider.

Anything else we need to know?: NA

Environment:

NA