search

gardener / machine-controller-manager

Declarative way of managing machines for Kubernetes cluster
Apache License 2.0
256 stars 117 forks source link

Added `Architecture` in NodeTemplate #894

Closed sssash18 closed 8 months ago

sssash18 commented 8 months ago

What this PR does / why we need it: This PR adds architecture field in the node template Which issue(s) this PR fixes: Fixes part of #https://github.com/gardener/autoscaler/issues/122

Special notes for your reviewer:

Release note:

Architecture field added in the nodetemplate. This will allow CA to pickup architecture from machine class and schedule pods on relevant arch nodes.
sssash18 commented 8 months ago

You have added architecture as a required field. Is it a required field, though? It is needed only in case of arm64 nodes, right? Can we keep it as an optional field?

Yes could be done , because by default the node will always have amd64 as arch label. This is true in gardener scenario. But for standalone mcm , this can lead to a case when pod with amd64 affinity might not get scheduled as the node does not have any arch field even though the node is amd64.

unmarshall commented 8 months ago

Looks good. Please add a release note in the PR.