search

gardener / machine-controller-manager

Declarative way of managing machines for Kubernetes cluster
Apache License 2.0
257 stars 117 forks source link

Fix gardener_local_setup script to use correct control cluster namespace #935

Closed thiyyakat closed 3 months ago

thiyyakat commented 3 months ago

What this PR does / why we need it: This PR fixes a bug where the shoot-- prefix was not added to the control cluster namespace in the gardener local setup case.

Control cluster namespaces in gardener always start with shoot-- prefix. This was erroneously removed in #928.

Which issue(s) this PR fixes: Fixes #

Special notes for your reviewer:

Release note:

Fixed bug that removed the shoot-- prefix from control cluster namespace for integration tests using the gardener local setup case
CLAassistant commented 3 months ago

CLA assistant check
All committers have signed the CLA.

gardener-robot commented 3 months ago

@thiyyakat Thank you for your contribution.

gardener-robot-ci-1 commented 3 months ago

Thank you @thiyyakat for your contribution. Before I can start building your PR, a member of the organization must set the required label(s) {'reviewed/ok-to-test'}. Once started, you can check the build status in the PR checks section below.