gardener / monitoring

Components needed for Gardener monitoring
Apache License 2.0
1 stars 3 forks source link

☂️ Use the prometheus-operator to manage Gardener's monitoring stacks #14

Open wyb1 opened 2 years ago

wyb1 commented 2 years ago

Stories

Motivation

Switching to the Prometheus operator promises a huge improvement for how components can define what to scrape and what to visualise.

Acceptance Criteria

Enhancement/Implementation Proposal

timebertt commented 2 years ago

General remark/advice: when implementing the GEP, you probably want to consider upfront how the feature will be verified in e2e tests. E.g., you could add some (dummy) ServiceMonitors in provider-local (similar to how other extensions would do it) and add some verifications to the default e2e, that talk to prometheus and ensure the required metrics are available. This is similar to what we do for testing the CA rotation feature parts that are contained in the extensions library :)

This will greatly improve the stability of the feature right from the beginning. Considering that this feature will probably not be tested manually during development, it is easy to regress. So having test coverage for that will significantly ease our lives :D