`etcdctl` precalculated argument values are validated before preset.

gardener / ops-toolbelt

Useful tools and operations guide for gardener landscapes

Apache License 2.0

15 stars 26 forks source link

`etcdctl` precalculated argument values are validated before preset. #116

Closed mimiteto closed 7 months ago

mimiteto commented 7 months ago

What this PR does / why we need it: etcdctl precalculated argument values are validated before preset. If deemed inappropriate hinting message is printed.

Which issue(s) this PR fixes: Fixes #

Special notes for your reviewer:

Release note:

`etcdctl` precalculated arguments are validated before set. If deemed inappropriate, hint is printed for the operator to set the correct values.

petersutter commented 7 months ago

Screenshot 2024-04-11 at 11 26 07 Some suggestions:

Texts like Certificate not found in the expected path. should be displayed with warning color
The suggestions like You can use --cert=/path/to/file should not display with error color, it's just a hint and should have the info color / no color
maybe also print the path where the script was looking for the files

mimiteto commented 7 months ago

It is info at the end of the day. I don't have an opinion here.