gardener / ops-toolbelt

Useful tools and operations guide for gardener landscapes
Apache License 2.0
15 stars 26 forks source link

Add crictl #19

Closed danielfoehrKn closed 2 years ago

danielfoehrKn commented 4 years ago

What would you like to be added:

Consider adding the debugging tool crictl for CRI deamons. See the available functionality here.

Why is this needed:

Soon Gardener will have support for different ContainerRuntimes (gvisor & KataContainers) see here. The crictl tool could be a good addition to docker cli and ctr cli (when containerd is available).

Note:

crictl per default connects to the dockershim on unix:///var/run/dockershim.sock. When running on a node that has CRI enabled (labels on node) then crictl should connect to the containerd socket unix:///run/containerd/containerd.sock.

danielfoehrKn commented 4 years ago

Closing this for now as it might be better to add this tool on the Node Os image itself. Edit: decided for now to not add it to the node as it is no strict requirement to have it plus there are ctr and runsc already preinstalled. Crictl could be a good addition in the toolbelt when running as a root pod.

neo-liang-sap commented 4 years ago

i will work on this issue, please assign this to me, thanks!

danielfoehrKn commented 4 years ago

Thanks for taking care of it!

neo-liang-sap commented 4 years ago

PR opened https://github.com/gardener/ops-toolbelt/pull/21

neo-liang-sap commented 3 years ago

will open new ticket for adding nerdctl instead of crictl /close

vlerenc commented 2 years ago

/reopen I am missing crictl. Could you please check why it's not (anymore?) in the image? I checked the non-suffix and the AWS/1.21 versions, but it's not there, I believe. Or am I wrong? Where should it be?

cc @neo-liang-sap @plkokanov @jfortin-sap

plkokanov commented 2 years ago

Hey, @vlerenc we only add nerdctl in the images, since it was decided that it's a bit more flexible and easier to use: https://github.com/gardener/ops-toolbelt/pull/21#issuecomment-871177059 If crictl is really necessary and there's something that you can do with it but not with nerdctl then we could add it.

cc @petersutter

vlerenc commented 2 years ago

/close Ah, thank you! I changed the labels/titles now.