search

gardener / ops-toolbelt

Useful tools and operations guide for gardener landscapes
Apache License 2.0
15 stars 26 forks source link

add nerdctl #58

Closed neo-liang-sap closed 3 years ago

neo-liang-sap commented 3 years ago

What this PR does / why we need it: add nerdctl per discussion in

Which issue(s) this PR fixes: Fixes https://github.com/gardener/ops-toolbelt/issues/56

Special notes for your reviewer:

Release note:

neo-liang-sap commented 3 years ago

local testing results: image

petersutter commented 3 years ago

I don't think we need to use the full version of nerdctl (with full in the download name) since we would just need the CLI access. Also it is 173 MBs which is too big for the ops image.

Good point, 173 MB is way too much.
Btw, meanwhile there is a v0.10.0 release.

neo-liang-sap commented 3 years ago

thanks, i've fixed per comments and testing looks like below image

neo-liang-sap commented 3 years ago

seems there are some network failure in CI building phase

Err:1 http://archive.ubuntu.com/ubuntu bionic InRelease
  Temporary failure resolving 'archive.ubuntu.com'
Err:2 http://security.ubuntu.com/ubuntu bionic-security InRelease
  Temporary failure resolving 'security.ubuntu.com'
Err:3 http://archive.ubuntu.com/ubuntu bionic-updates InRelease
  Temporary failure resolving 'archive.ubuntu.com'
Err:4 http://archive.ubuntu.com/ubuntu bionic-backports InRelease
  Temporary failure resolving 'archive.ubuntu.com'
Reading package lists... Done
gardener-robot commented 3 years ago

@neo-liang-sap You have pull request review with status CHANGES_REQUESTED, please check