search

gardener / ops-toolbelt

Useful tools and operations guide for gardener landscapes
Apache License 2.0
15 stars 26 forks source link

fix install_k9s script #90

Closed petersutter closed 1 year ago

petersutter commented 1 year ago

What this PR does / why we need it: This PR adapts the install_k9s script to the current naming scheme for the k9s tarball as it has changed with v0.27.0.

Which issue(s) this PR fixes: Fixes #89

Special notes for your reviewer:

Release note:

Fixed `install_k9s` script
plkokanov commented 1 year ago

/lgtm

plkokanov commented 1 year ago

/hold Actually, should we still keep the old naming scheme if the version is specified and it is v0.26.0 or lower?

petersutter commented 1 year ago

In the past the naming scheme for the build results was changed several times and we haven't supported it there either. The main reason that I added the option to specify a different version than latest was that sometimes in the past it happened that the latest k9s release had severe issues where you would want to switch to one of the previous releases where the issues did not occur. As of now I'm not aware of a use case where you would want to install an arbitrary old version of k9s. For these reasons I'd suggest to keep the script simple and stupid

plkokanov commented 1 year ago

/unhold