Closed dergeberl closed 3 months ago
@dergeberl Thank you for your contribution.
Thank you @dergeberl for your contribution. Before I can start building your PR, a member of the organization must set the required label(s) {'reviewed/ok-to-test'}. Once started, you can check the build status in the PR checks section below.
Regarding memory usage these are my major findings:
vpn-seed-server-665cf779b9-52vwb 3m 19Mi
---
vpn-shoot-f956748d-gv5h5 5m 1Mi
Without the script, on Linux the memory consumption was ~ 6Mi
@dergeberl You need rebase this pull request with latest master branch. Please check.
With ha vpn we have the shoot-client container running in the seed in the kube-apiserver pod. This is already confusing. The path-controller is only needed in seed. Maybe, we should we use the opportunity to separate seed-client and shoot client? Or change the name from shoot-client
to vpn-client
?
With ha vpn we have the shoot-client container running in the seed in the kube-apiserver pod. This is already confusing. The path-controller is only needed in seed. Maybe, we should we use the opportunity to separate seed-client and shoot client? Or change the name from
shoot-client
tovpn-client
?
As we need to rename the images anyway to be able to switch back to the old implementation, I propose to use vpn-client
instead of shoot-client
for package and image name and similar vpn-server
instead of seed-server
.
I don't see a big win in separating "seed-client" and "shoot-client", as they share many things.
/lgtm
/lgtm
Open Tasks:
pathcontroller
ls
)What this PR does / why we need it:
This PR rewrites the bash scripts into go. This will made it easier to adopt to new features in the future.
initContainers
use a subcommandiproute2
is now done with thenetlink
packageDockerfile
s into oneDockerfile
Co-authored-by: @MartinWeindel Co-authored-by: @hown3d Co-authored-by: @mreiger
Which issue(s) this PR fixes: Fixes #
Special notes for your reviewer: ⚠️ The pipeline jobs for building images are failing as changes in
.ci/pipeline_definitions
are not yet used. They become only active after merging to master branch.⚠️ This is a breaking change and needs also changes to gardener/gardener
Release note: