search

gardener / vpn2

Network connector between the control plane (deployed in a Seed cluster) and a Shoot cluster superseding the vpn repository.
Apache License 2.0
5 stars 20 forks source link

Use IPv6 VPN transfernetwork #99

Closed MartinWeindel closed 3 weeks ago

MartinWeindel commented 1 month ago

What this PR does / why we need it: Replace the existing 192.168.123.0/24 network which is currently in use for the VPN transfer network with an IPv6 ULA address space. This frees the usable networks ranges for shoots.

Which issue(s) this PR fixes: Fixes #

Special notes for your reviewer: This PR is based on the work done in PR #83, but now using Go instead of bash scripts.

Release note:

Introduce IPv6 VPN transfer network to get rid of blocked IPv4 network /24 range used for VPN.
axel7born commented 1 month ago

I had a hard time to understand the purpose of the new tunnel controller. I still don't understand why it's needed for the ipv6 vpn-network but not for ipv4. Could it be possible, that there is not just a configuration option missing in vpn config? Adding a route is not a big issue for the non-HA case, but for HA there is a lot of added complexity with the new controller. Do we want to enable that for existing shoots, that work well with the current setup and don't need the extra address space? Maybe we should add a flag to only enable it, when needed?

gardener-robot commented 3 weeks ago

@MartinWeindel You need rebase this pull request with latest master branch. Please check.

ScheererJ commented 3 weeks ago

/lgtm