search

gardenlinux / gardenlinux-nvidia-installer

3 stars 7 forks source link

Allow usage of an existing image pull secret #14

Closed patrickhuy closed 11 months ago

patrickhuy commented 11 months ago

What this PR does / why we need it: Allows the usage of an existing image pull secret instead of creating a new one

A new key global.imagePullSecrets can be used to specify a list of already existing imagePullSecrets to use.

Special notes for your reviewer: The pattern I followed here seems to be somewhat common, it is applied like this in bitnami helm charts (for example here https://github.com/bitnami/charts/blob/main/bitnami/nginx-ingress-controller/values.yaml#L18 but also in others https://github.com/prometheus-community/helm-charts/blob/main/charts/kube-prometheus-stack/values.yaml#L218 ) This implementation requires the full Kubernetes style format of - name : mySecretName instead of a simplified form like - mySecretName I believe it is better to do what Kubernetes does in order not to surprise users here.

The existing mechanism via global.imagePullSecret to create a secret is left intact but disabled by default.

Release note:

Allows the usage of pre-existing image pull secrets instead of creating new ones by specifying `global.imagePullSecrets`