search

gardenlinux / gardenlinux-nvidia-installer

3 stars 7 forks source link

give distinct labels to device-plugin and nvidia-installer when nameOverride is set #15

Closed patrickhuy closed 11 months ago

patrickhuy commented 11 months ago

What this PR does / why we need it: give distinct labels to decide plugin and nvidia-installer when nameOverride is set

Special notes for your reviewer: These are used in the labels of the 2 daemonsets:

https://github.com/gardenlinux/gardenlinux-nvidia-installer/blob/12e1cf37fa62dc34f17841a53a6590750be45ff1/helm/templates/ds-k8s-nvidia-deviceplugin.yaml#L9-L16

https://github.com/gardenlinux/gardenlinux-nvidia-installer/blob/12e1cf37fa62dc34f17841a53a6590750be45ff1/helm/templates/ds-nvidia-installer.yaml#L15-L22

Having both daemonsets use the identical label selector would not be great which currently happens when setting nameOverride. Additionally by default the labels now include the release-name

Release note:

distinct labels for installer and deviceplugin daemonset created pods