gardenlinux / glci

CI/CD utils for Garden Linux
MIT License
2 stars 2 forks source link

Missing vm image features on Azure since publishing with CommunityGalleries #58

Closed MrBatschner closed 3 months ago

MrBatschner commented 7 months ago

What happened:

VM Images on Azure have guest os features that specify what the OS can do.

E.g. from a SUSE cHost Image:

$ az vm image show --urn suse:sles-15-sp5-chost-byos:gen2:2024.03.07
{
  [...]
  "features": [
    {
      "name": "SecurityType",
      "value": "TrustedLaunchSupported"
    },
    {
      "name": "IsAcceleratedNetworkSupported",
      "value": "True"
    },
    {
      "name": "DiskControllerTypes",
      "value": "SCSI, NVMe"
    },
    {
      "name": "IsHibernateSupported",
      "value": "True"
    }
  ],
  [...]
}

The feature IsAcceleratedNetworkSupported is of notable interest since Garden Linux supports it and it is actively used in Gardener. However, it was never set to true even during times when Garden Linux published through Azure Marketplace:

$ az vm image show --urn sap:gardenlinux:greatest:934.11.0
{
  [...]
  "features": [
    {
      "name": "IsAcceleratedNetworkSupported",
      "value": "False"
    },
    {
      "name": "DiskControllerTypes",
      "value": "SCSI"
    },
    {
      "name": "IsHibernateSupported",
      "value": "False"
    }
  ],
  [...]
}

Setting the feature list is done in the galleryImageDefinition by providing a features element (ref, ref) containing allowed features.

Things to do:

MrBatschner commented 5 months ago

Relevant code changes here: https://github.com/MrBatschner/glci/commit/6487d1a6315ebeab180c7ca417ebd8303a92e81e Still, the bullet points above need to be worked on.