search

gardenlinux / glci

CI/CD utils for Garden Linux
MIT License
2 stars 2 forks source link

Default path of gardenlinux/builder seems a bit strage #59

Closed fwilhe closed 1 month ago

fwilhe commented 6 months ago

Here it is assumed that https://github.com/gardenlinux/builder is cloned to a dir gardenlinux-builder. But git's default is to call the clone dir like the repo name, so it's more likely to have a directory called builder in that place.

Maybe we could just check for both, not sure if this might introduce a regression for anyone relying on the old behaviour.

MrBatschner commented 3 months ago

Reason for that is that if you maintain a fairly flat directory hierarchy on your filesystem (like the author of that particular piece of code), builder is not really a descriptive name for a directory, hence the gardenlinux- prefix. However, your remark absolutely makes sense and the default directory can always be overridden with the env variable GARDENLINUX_BUILDER_PATH. Feel free to change it but keep in mind that several pipeline definitions not hosted in this repository/org might need to be altered too.