search

gardr / validator

MIT License
3 stars 0 forks source link

Add support for AdForm clickTAG #30

Closed OleSan closed 8 years ago

OleSan commented 10 years ago

AdForms clickTAG isn't detected as a real clickTAG in the current validation. It would be of massive help if it could check for this clickTAG in the validation process.

The code for mobile is: http://jsfiddle.net/01ce502e/

If this isn't included in the adform tag, it won't open up in a new window. The click will open it in the current webview its in.

I think the validator already can detect if its an adform tag, since we remove the limit of scripts from the errors? Would be nice to just add a rule for this instead of the other click method we currently use in our INMA spec.

sveisvei commented 10 years ago

Do Adform use a generic way to expose clickTags? Does the spec want to get info around this?

OleSan commented 10 years ago

You can see an AdForm template banner here http://test.adform.com/banners/Specifications/finn/templates/Responsive_Leaderboard.zip

The URL gets collected from manifest.js file so they don't need to hardcode the URL in the creatives. Then they can add that later in the AdForm UI.

sveisvei commented 10 years ago

Its not exposed inside the banner-iframe.

If we where to check on "window.clickTAGvalue" inside their homegrown "about:blank" iframe then it might break whenever they change the Adform dhtml library.

The "spec" should have one way to expose clickTags?