gardr / validator

MIT License
3 stars 0 forks source link

Add support for detecting folder structure in the creative #39

Closed OleSan closed 9 years ago

OleSan commented 9 years ago

This relates to a new point in the HTML spec. Point 5, Banner delivery.

It should detect if the zip-file has a folder structure for the assests or not, and give an error if it does.

sveisvei commented 9 years ago

Should it generate a warning or an error? Should it only generate given error/warning when testing via zip-upload?

OleSan commented 9 years ago

Good questions!

It should be an error, as uploading it to say AdTech will break it if it includes folders. So it is pretty critical.

The validation should probably only be for zip-files, but I'll double check that with some people from AdOps first what they think.

OleSan commented 9 years ago

AdOps say we can start with only checking on zip uploads.

sveisvei commented 9 years ago

This will have to be done on the web-app/validator-web that processes the zip.

sveisvei commented 9 years ago

https://github.com/gardr/validator-web/commit/901f244d4521e3a157bb88c626c9dbb9b0eef86e