Heatsoak macro is not pausing on Octoprint

garethky / klipper-voron2.4-config

Klipper Config for my Voron 2.4

93 stars 10 forks source link

Heatsoak macro is not pausing on Octoprint #10

Closed SinisterRj closed 10 months ago

SinisterRj commented 11 months ago

Hi Gareth,

The {% set is_print_active = printer['virtual_sdcard'].is_active or printer['virtual_sdcard'].file_position != 0.0 %} line on heatsok,cfg is not abble to set if the printer is running or not when using Octoprint instead Mainsaill.

garethky commented 11 months ago

So as you can probably tell from that line I am having to guess if a print is running. I don't use Octoprint so I cant easily investigate this myself.

Questions I have are:

What is Octoprint doing to run a print that doesn't use the virtual_sdcard?
How should we know that Octoprint is running a print? Is there some other object that we should look at?

SinisterRj commented 10 months ago

This is what worked for me:

{% set is_print_active = printer['virtual_sdcard'].is_active or printer['virtual_sdcard'].file_position != 0.0 or printer.idle_timeout.state == 'Printing' %}

And I really don't know what Octoprint does.. Lol.

P.S.: Sorry for the delay.

garethky commented 10 months ago

Oh thats cool! I guess I need to go back and see if this needs checking anywhere else that I look at the state of the virtual_sdcard. Maybe this is better test for "is printing" in general.