search

garethr / garethr-docker

Puppet module for managing docker
Apache License 2.0
397 stars 528 forks source link

Flag '--cpuset' doesn't exist #448

Open sege opened 8 years ago

sege commented 8 years ago

Using module version 5.1.1.

Flag '--cpuset' doesn't exist with Docker 1.10. Output when trying to start: " Starting docker-elasticsearch: flag provided but not defined: --cpuset"

From init-script: " printf "Starting $prog:\t" $docker rm elasticsearch >/dev/null 2>&1 $docker run \ --net bridge -m 0b --cpuset=0-7 .."

Hiera-conf: " docker::run_instance::instance: elasticsearch: image: 'elasticsearch:2.2' cpuset: '0-7' ..."

I think it should be '--cpuset-cpus' according to the docs: https://docs.docker.com/engine/reference/run/#runtime-constraints-on-resources

petems commented 8 years ago

Yep, looks like it was deprecated: https://docs.docker.com/engine/deprecated/

The following double-dash options are deprecated and have no replacement:

docker run --cpuset

Should be a quick fix, let me PR :smile:

rogierslag commented 7 years ago

Can I submit a PR for this new behaviour?