'list_instances_of' fails to correctly pluralize resource names that end in 's'

garethr / garethr-kubernetes

Puppet types and provider for managing Pods, ReplicationControllers, Services and more in Kubernetes

http://garethr.github.io/garethr-kubernetes

Apache License 2.0

28 stars 28 forks source link

'list_instances_of' fails to correctly pluralize resource names that end in 's' #43

Closed tmick0 closed 6 years ago

tmick0 commented 6 years ago

The linked line of code does not correctly pluralize resources that end in 's' such as 'ingress'. Given this input, it should call a function called 'get_ingresses' however instead it attempts to call 'get_ingresss' which does not exist. As a result, this module cannot be used to automate creation of ingress resources.

https://github.com/garethr/garethr-kubernetes/blob/2902cc347e5ac48d0921814e5084a015d31f2e58/lib/puppet_x/puppetlabs/kubernetes/provider.rb#L73

tmick0 commented 6 years ago

Turns out this is a duplicate of #8 , will close this