garethr / garethr-kubernetes

Puppet types and provider for managing Pods, ReplicationControllers, Services and more in Kubernetes
http://garethr.github.io/garethr-kubernetes
Apache License 2.0
28 stars 28 forks source link

Endpoints plural form and subsets array is not correctly handled #8

Open khaliullov opened 8 years ago

khaliullov commented 8 years ago

I've found some problems with your cool module while creating Endpoints in Kubernetes:

I've created temporary workaround, but I am bad in Ruby, so, could you please fix it in proper way?

https://github.com/khaliullov/garethr-kubernetes/commit/bcc418cb7168ffd119790820b25bee38b8894bd3

garethr commented 8 years ago

@khaliullov thanks for reporting, and for the work around. I'd managed to have notifications off for this repo and missed this. I'll take a look when I get a moment. Thanks!

ross-w commented 7 years ago

I'm having this issue as well. It was doing my head in as endpoints seem to be the only thing we are using that is affected!

tmick0 commented 6 years ago

I also ran into this problem. Didn't see this issue so made a duplicate #43 and immediately closed it.