search

garethr / garethr-riemann

Puppet module for Riemann, published on the Puppet Forge
https://forge.puppetlabs.com/garethr/riemann
Apache License 2.0
16 stars 19 forks source link

Manage config for saving riemann dashboard config to s3. #15

Open heartpunk opened 9 years ago

heartpunk commented 9 years ago

This is pretty much working, but might need some cleanup to get up to snuff (I'm still relatively new to puppet). One known hole is that the default value for for use_s3 doesn't work. I don't know how to fix it, but I figure you might (or perhaps my fine fellow udacian, @ods94065, knows how?).

Happy to work out any concerns you have to get this merged, just let me know what needs doing. Would be nice to get #14 in shortly thereafter, too, so we can switch back to using the version from the forge.

garethr commented 9 years ago

Thanks for this, I've left a bunch of comments that should help you resolve your issue, and fix a few other bits. Feel free to ask any questions, happy to help.

heartpunk commented 9 years ago

@garethr I believe I've resolved all the issues, including fixing what seems to be a new issue introduced by a dependency (switched the license identifier over to a standard format). Unfortunately, the 1.8.7 builds are failing, and I can't isolate the problem easily. Any thoughts on how to resolve the remaining build failures?

heartpunk commented 9 years ago

(will of course clean up the commits before we're ready for merge.)

heartpunk commented 9 years ago

Looks like the remaining failing test may be caused by this issue.