search

garethr / garethr-riemann

Puppet module for Riemann, published on the Puppet Forge
https://forge.puppetlabs.com/garethr/riemann
Apache License 2.0
16 stars 19 forks source link

Allow user to specify mirror location for Riemann archive #17

Open standaloneSA opened 9 years ago

standaloneSA commented 9 years ago

I'm on a protected network where I can't connect to aphyr to grab the archives, so I extended the module to allow me to specify the mirror URL.

Please let me know if you have any questions. Thanks!

--Matt

standaloneSA commented 9 years ago

In case you don't see it, I ended up moving this over to the new Travis infrastructure (by setting sudo: false), and (forgive me), I commented out the checks against Ruby 1.8.7. When I made the comment, I thought it was a rspec regression as the title of this thread suggests:

https://github.com/rspec/rspec-core/issues/1864

But as Myron Marston demonstrated, it's actually a problem with Puppet. I don't feel like I know enough to decide what's best going forward, and whether you want to limit support for those combined versions of puppet / rspec,

If there's anything I can do, please let me know.

thanks!

--Matt