search

garethr / garethr-riemann

Puppet module for Riemann, published on the Puppet Forge
https://forge.puppetlabs.com/garethr/riemann
Apache License 2.0
16 stars 19 forks source link

Deprecated variable usage #9

Closed dowlingw closed 11 years ago

dowlingw commented 11 years ago

Including riemann modules generates warnings for usage of deprecated variables under Puppet 3.

Warning: Variable access via 'user' is deprecated. Use '@user' instead. template[/etc/puppet/modules/riemann/templates/etc/init/riemann.conf.erb]:7
   (at /etc/puppet/modules/riemann/templates/etc/init/riemann.conf.erb:7:in `result')
Warning: Variable access via 'config_file' is deprecated. Use '@config_file' instead. template[/etc/puppet/modules/riemann/templates/etc/init/riemann.conf.erb]:12
   (at /etc/puppet/modules/riemann/templates/etc/init/riemann.conf.erb:12:in `result')
Warning: Variable access via 'host' is deprecated. Use '@host' instead. template[/etc/puppet/modules/riemann/templates/etc/puppet/riemann.yaml.erb]:2
   (at /etc/puppet/modules/riemann/templates/etc/puppet/riemann.yaml.erb:2:in `result')
Warning: Variable access via 'port' is deprecated. Use '@port' instead. template[/etc/puppet/modules/riemann/templates/etc/puppet/riemann.yaml.erb]:3
   (at /etc/puppet/modules/riemann/templates/etc/puppet/riemann.yaml.erb:3:in `result')
Warning: Variable access via 'user' is deprecated. Use '@user' instead. template[/etc/puppet/modules/riemann/templates/etc/init/riemann-dash.conf.erb]:7
   (at /etc/puppet/modules/riemann/templates/etc/init/riemann-dash.conf.erb:7:in `result')
Warning: Variable access via 'host' is deprecated. Use '@host' instead. template[/etc/puppet/modules/riemann/templates/etc/riemann-dash.rb.erb]:1
   (at /etc/puppet/modules/riemann/templates/etc/riemann-dash.rb.erb:1:in `result')
Warning: Variable access via 'port' is deprecated. Use '@port' instead. template[/etc/puppet/modules/riemann/templates/etc/riemann-dash.rb.erb]:2
   (at /etc/puppet/modules/riemann/templates/etc/riemann-dash.rb.erb:2:in `result')
Warning: Variable access via 'health_user' is deprecated. Use '@health_user' instead. template[/etc/puppet/modules/riemann/templates/etc/init/riemann-health.conf.erb]:7
   (at /etc/puppet/modules/riemann/templates/etc/init/riemann-health.conf.erb:7:in `result')
Warning: Variable access via 'net_user' is deprecated. Use '@net_user' instead. template[/etc/puppet/modules/riemann/templates/etc/init/riemann-net.conf.erb]:7
   (at /etc/puppet/modules/riemann/templates/etc/init/riemann-net.conf.erb:7:in `result')
garethr commented 11 years ago

Thanks for the report. I think I've fixed these warning, and a few other minor style things, in https://github.com/garethr/garethr-riemann/commit/42ea201e2883d581c8c564de7cbd8977e96f73f7

This is now released as 0.5.1 on the Forge too. Cheers