search

garethr / librarian-puppet-vagrant

Vagrant middleware to run librarian puppet before each vagrant up and vagrant provision
MIT License
12 stars 3 forks source link

Don't call librarian-puppet through CLI #1

Open patcon opened 11 years ago

patcon commented 11 years ago

Re: https://github.com/garethr/librarian-puppet-vagrant/blob/master/lib/librarian/puppet/vagrant.rb#L10 I'm sure this was simply how you did it as a proof of concept, but I don't think it works so well when bundle exec is required.

How vagrant-librarian does it: https://github.com/thegcat/vagrant-librarian/blob/master/lib/vagrant-librarian/install.rb

Cheers!

patcon commented 11 years ago

Ah oops. I get it. It's so that you don't need to depend on librarian itself, which comes with a big dep on chef.

@yfeldblum I know you were talking about extracting librarian-chef into its own project at some point. Is that still in the cards? I'm guessing this explains which librarian-puppet project is nesting the librarian code as well, instead of adding a dependency...? https://github.com/rodjek/librarian-puppet/tree/master/vendor

cc @rodjek

yfeldblum commented 11 years ago

Librarian-Chef is extracted into its own project now.

That means: Librarian has no dependency on Chef now.

blalor commented 11 years ago

I would really like to see this Vagrant plugin include librarian on its own, rather than shelling out to it.