garethr / puppet-module-skeleton

A pretty opinionated skeleton for writing your own puppet modules
Apache License 2.0
309 stars 152 forks source link

Travis tests fail running on the bare module skeleton #94

Open Rovanion opened 8 years ago

Rovanion commented 8 years ago

Looking at the following test results generated by travis for an empty skeleton generated by this repository: https://travis-ci.org/Rovanion/test-module

It seems as if the dependency named rainbow no longer supports ruby < 1.9.2 and as of such the tests fail. I'm not sure if the right course of action is to remove support for older ruby versions, and with that support for Debian 6 and I assume a lot of Red Hat versions, or to in some way specify that we want an older version of rainbow for the older ruby versions.

garethr commented 8 years ago

Ah, good spot. I'm happy to see that pinned for the moment.

Rovanion commented 8 years ago

But since rainbow is a dependency rubocop and specifying that we want a lower version ends up with a dependency error. The lowest version of rainbow rubocop allows is 1.99.1 and pinning that has the same effect I'm afraid: https://travis-ci.org/Rovanion/test-module/jobs/91128360