[feature]: Form for creating/updating of a student

garg3133 / JagratiWebApp

Official WebApp of Jagrati - An Initiative of IIITians

https://jagrati.iiitdmj.ac.in

MIT License

47 stars 130 forks source link

[feature]: Form for creating/updating of a student #263

Closed harshakhmk closed 3 years ago

harshakhmk commented 3 years ago

We can have a form for adding new student details and updating existing student details in apps/students folder
I would like to implement the request payload through Django forms instead of hard-coding them.
Through forms, we can have better error handling

I would like to work on this @garg3133

Jagrati-Bot commented 3 years ago

Hi! Thanks for opening your first issue at JagratiWebApp :rocket: We really appreciate it. :raised_hands: Someone from our team will get back here soon.

garg3133 commented 3 years ago

Yes, I agree with you that using django forms would be better. Surely you can work on this. Assigning it to you.

harshakhmk commented 3 years ago

Shall I also change HTML forms with Django forms when a GET request is made

garg3133 commented 3 years ago

@harshakhmk Yes, you can, but just make sure that it does not affect the page structure and design.

harshakhmk commented 3 years ago

I handled POST data using forms, shall I be raising separate MR for updating HTML code with Django forms or should I be rasing in the same MR with a different commit

garg3133 commented 3 years ago

You can do that in the same PR.

harshakhmk commented 3 years ago

@garg3133 I have raised the PR 274