search

gargankit90 / TwitterClient

0 stars 0 forks source link

Android BootCamp code review #1

Open gargankit90 opened 10 years ago

gargankit90 commented 10 years ago

Hey, I have completed all required stories plus i also did the optional one to store user info in DB. Working on storing tweets in DB. @nesquena

vibhorB commented 10 years ago

Decent work Ankit. A few notes after checking out the code:

Here's a detailed Project 3 Feedback Guide here which covers the most common issues with this submitted project. Read through the feedback guide point-by-point to determine how you could improve your submission.

Let us know if you have any other thoughts or questions about this assignment. Hopefully by now you feel pretty comfortable with all the major pieces to basic Android apps (Views, Controllers, ActionBar, Navigation, Models, Authentication, API Communication, Persistence, et al) and see how they all fit together. We are close now to a turning point in the course where you should be hitting a "critical mass" towards your knowledge of Android.

nesquena commented 10 years ago

@gargankit90 Can you respond back here after correcting the timestamp to be relative? See project hints guide.

gargankit90 commented 10 years ago

I can complete this today. shouldnot be difficult.

Thanks, Ankit Garg On Jun 25, 2014 11:36 PM, "Nathan Esquenazi" notifications@github.com wrote:

@gargankit90 https://github.com/gargankit90 Can you respond back here after correcting the timestamp to be relative? See project hints guide.

— Reply to this email directly or view it on GitHub https://github.com/gargankit90/TwitterClient/issues/1#issuecomment-47192248 .

gargankit90 commented 10 years ago

Hey,

Updated code to have relative timestamp.

Sorry i have a release going out next week.

Thanks, Ankit Garg On Jun 26, 2014 7:14 AM, "Ankit Garg" gargankit90@gmail.com wrote:

I can complete this today. should not be difficult.

Thanks, Ankit Garg On Jun 25, 2014 11:36 PM, "Nathan Esquenazi" notifications@github.com wrote:

@gargankit90 https://github.com/gargankit90 Can you respond back here after correcting the timestamp to be relative? See project hints guide.

— Reply to this email directly or view it on GitHub https://github.com/gargankit90/TwitterClient/issues/1#issuecomment-47192248 .

vibhorB commented 10 years ago

@gargankit90 I checked the changes in code, looks ok, but pls make sure to update GIF also.

Thanks Vibhor