search

garganurag893 / react-native-phone-number-input

React Native component for phone number.
MIT License
373 stars 216 forks source link

Better country flags #71

Open TanKucukhas opened 2 years ago

TanKucukhas commented 2 years ago

I know to save on the size we are using native country flags here. To make this library more usable I think we need to consider adding custom flags. Current flags look really bad on some designs. Would it be possible to expose flags so that we can pass our own flag icons or any? I'm open to contribute to this as well.

For instance, we can use this pack with MIT pack;

https://iconscout.com/icon-pack/country-flags

TanKucukhas commented 2 years ago

@garganurag893 just added a PR. Could you review it? It turns out react-native-country-picker-modal already have this option. I just exposed it by adding an optional boolean.

this is how it looks like. Looks much better than emoji flags in my opion.

Screen Shot 2021-10-08 at 8 20 21 PM
jordiup commented 2 years ago

I've checked out #72 and it looks good, simple change!

@garganurag893 it would be awesome to see this go live, I'm hoping to squeeze it into one of our sprint cycles 😅, thanks for the awesome repo

Cmoen11 commented 2 years ago

Is this repo dead? why is this PR being stalled?

FR073N commented 2 years ago

Any new on this one ?

TanKucukhas commented 2 years ago

It looks like all CountryPickerProps is already exposed. So no PR is needed. Above can be achieved by passing this;

  <PhoneInput countryPickerProps={{withEmoji: false, renderFlagButton: null}} />