garimasingh128 / Hacktoberfest2020-MovieDo

๐Ÿคช ๐Ÿคจ ๐Ÿง ๐Ÿค“ ๐Ÿ˜Ž HACKTOBERFEST 2020 ALERT: Submit Just 4 PRs to earn SWAGS ๐Ÿคช ๐Ÿคจ ๐Ÿง ๐Ÿค“ ๐Ÿ˜Ž Make your first PR! ~ A beginner-friendly repository made specifically for open source beginners.
https://moviedo.netlify.app
Other
83 stars 265 forks source link

Add the favicon #13

Open mrinal4 opened 3 years ago

mrinal4 commented 3 years ago

Create and add favicon for your website which will make it more spectacular.

issue-label-bot[bot] commented 3 years ago

Issue-Label Bot is automatically applying the label feature_request to this issue, with a confidence of 0.98. Please mark this comment with :thumbsup: or :thumbsdown: to give our bot feedback!

Links: app homepage, dashboard and code for this bot.

Halix267 commented 3 years ago

@mrinal41298 I want to work on this issue .Plzz assign it to me.

Vrindagupta6828 commented 3 years ago

@mrinal41298 please assign me this to me

ShubhamSood1406 commented 3 years ago

@mrinal41298 Do you want the favicon next to the MovieGo title of the website?

garimasingh128 commented 3 years ago

Yup. Just pick up a favicon which looks best acc to you in terms of design and simplicity and add it in index.html.

anproghub commented 3 years ago

@mrinal41298 please assign me this to me

Vrindagupta6828 commented 3 years ago

@mrinal41298 please can you tell me that only a single favicon can be added to a website so how can 2 people add favicon? Me and halix267 as you have assigned to both of us

garimasingh128 commented 3 years ago

Both of you can create a "Design" folder in the root of the repo and add your png images in that for the favicon.

Vrindagupta6828 commented 3 years ago

@garimasingh128 ok sure thanks

Vrindagupta6828 commented 3 years ago

@garimasingh128 I have added the folder please review it.

anproghub commented 3 years ago

@garimasingh128 sure

Vrindagupta6828 commented 3 years ago

@garimasingh128 please label my pull request as hacktoberfest accepted #57 so that it can count