paramsiddharth commented 3 years ago

Enhance App and Fix Bugs

This is a repeated PR due to problems with #33.

Issues Resolved

Resolves #11: Component Distribution
Resolves #21: axios promise isn't allowed to complete before redirection to root
Resolves #30: Update .gitignore

Modifications

Removed backend pollutants by clearing up the cache and recommitting changes. backend/node_modules is unnecessarily occupying nodes in the repository. When needed, one can do a fresh npm install or npm ci in the backend directory to get the back-end ready.

Updated .gitignore to exclude the backend/node_modules from further commits. The updated package.json and other required files will always be included.

backend
│
├── models
│   ├── exercise.model.js
│   └── user.model.js
├── package-lock.json
├── package.json
├── routes
│   ├── exercises.js
│   └── users.js
└── server.js

Fixed redirection issue with axios calls by enclosing the window.location assignments in .then() blocks.
```
...
.then(() => window.location = '/');
...
```
Create a <Footer /> component using the same Bootstrap style as used by the rest of the application.

Create a <CustomForm {#props} /> component for usage in the <CreateExercise /> and <EditExercise /> components. Why? Because both the components have the same form structure. The only difference is the text inside the submission button. Hence, we judiciously separate the application into components without code-repetition. The component accepts the desired methods and values as props.

<CustomForm
onSubmit={this.onSubmit}
onChangeUsername={this.onChangeUsername}
onChangeDescription={this.onChangeDescription}
onChangeDate={this.onChangeDate}
onChangeDueDate={this.onChangeDueDate}
onChangeDuration={this.onChangeUsername}
state={{
  users: this.state.users,
  username: this.state.username,
  date: this.state.date,
  ddate: this.state.ddate,
  duration: this.state.duration,
  description: this.state.description
}}
submitMessage={'<Submission Button Message>'}
/>

paramsiddharth commented 3 years ago

@garimasingh128 Please note that it would still show backend/node_modules and its contents in the "Files Changed" section because it was deleted.

garimasingh128 commented 3 years ago

Looks good. Change base to develop please.

paramsiddharth commented 3 years ago

Looks good. Change base to develop please.

Pardon! Let me change it.

paramsiddharth commented 3 years ago

Done!

garimasingh128 / ToDoista