search

garkimasera / vlc-rs

Rust bindings for libVLC media framework.
MIT License
66 stars 18 forks source link

Implement Instance args #1

Closed 0xpr03 closed 6 years ago

0xpr03 commented 6 years ago

Hi, I'm currently in need for some functions so expect more PRs to come :) I'm not that experienced in writing libs so tell me if any interfaces aren't that good.

garkimasera commented 6 years ago

Thank you for your PR.

I think it is better to add a new function with_args(args: Vec<String>) -> Instance to Instance type than change in new() function. In this case, there are no need to change existing code. What do you think about it?

0xpr03 commented 6 years ago

I think that's a good idea. Will work on that later on, currently busy with upstream.

0xpr03 commented 6 years ago

@garkimasera I've pushed it with with_args, I've used an Option to unify all instance creations.

0xpr03 commented 6 years ago

This works upstream for me.

0xpr03 commented 6 years ago

Pushed with changes, I think I get now why we get a dangling pointer otherwise.

garkimasera commented 6 years ago

Great! Thanks.