Closed JoshuaWatt closed 5 years ago
Hello @JoshuaWatt! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:
There are currently no PEP 8 issues detected in this Pull Request. Cheers! :beers:
Why did our code coverage go down?
Why did our code coverage go down?
I think because I removed 3 unused imports which were previously covered. This lowers the overall ratio of covered to uncovered lines... I'm not really worried about it
I am alright with this patch then. We should put up another patch to use the tool tox to handle test execution: https://tox.readthedocs.io/en/latest/ we could put the downloading of external requirements in there the all the developer would need to do is run "tox" to execute.
Reformats Python code according to pep8, and fixes up flake8 warnings.
Adds a lint script that can be run to fix up the code to be conformant in the future.
Updates the Travis CI tests to run flake8 as part of the automated tests