search

garmin / pyrex

Seamless container setup for developing with OpenEmbedded/Yocto Project
Apache License 2.0
36 stars 29 forks source link

Fix using terminal when $TERM is not set #50

Closed JoshuaWatt closed 4 years ago

JoshuaWatt commented 4 years ago

Changes Pyrex to no longer pass -t if $TERM is not set (or is empty) in the environment, and adds tests to ensure the happens correctly.

This fixes commands in the container issuing errors like:

tput: No value for $TERM and no -T specified
matthoosier-garmin commented 4 years ago

I'd thought that there generally isn't a problem with interactive sessions even when $TERM isn't set. Don't the shells generally fall back to vt100 mode in that case?

I'm just wondering whether we're giving up any usability here by making it impossible to get a pyrex shell when TERM doesn't happen to be defined.

JoshuaWatt commented 4 years ago

I'd thought that there generally isn't a problem with interactive sessions even when $TERM isn't set. Don't the shells generally fall back to vt100 mode in that case?

I'm just wondering whether we're giving up any usability here by making it impossible to get a pyrex shell when TERM doesn't happen to be defined.

We don't gain anything. I though this was the cause of a build failure we were seeing, but it turns out it was caused by another issue. I need to abandon this.