garmin / pyrex

Seamless container setup for developing with OpenEmbedded/Yocto Project
Apache License 2.0
38 stars 30 forks source link

Extract all kernel caps manually instead of relying on all flag #53

Closed awidegreen closed 3 years ago

awidegreen commented 3 years ago

The 'all' can lead to a mismatch of /proc/sys/kernel/cap_last_cap and CAP_LAST_CAP from /usr/include/linux/capability.h.

Issue:

setpriv: libcap-ng is too old for "all" caps

I faced the issue running a 5.8 kernel on Ubuntu 20.04.1 (HWE edge).

Not sure if that is something that you want to merge, but I thought you should at least be aware. It seems that the patch - which is applied via the Dockerfile - didn't seem to work.

Inspiration for the fix came from: https://github.com/SinusBot/docker/pull/40

pep8speaks commented 3 years ago

Hello @awidegreen! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! :beers:

Comment last updated at 2021-01-15 12:07:30 UTC
JoshuaWatt commented 3 years ago

Oops, sorry I missed this. I think this was fixed with #54. Please verify and reopen if that is not the case. Thanks!

awidegreen commented 3 years ago

updating to 1.2.0 seems to solve the issue as well!