search

garnaat / kappa

What precedes Lambda
http://kappa.readthedocs.org/en/develop/
Apache License 2.0
902 stars 89 forks source link

Adding support for environment variables #97

Closed BrunoCarrier closed 7 years ago

BrunoCarrier commented 7 years ago

Hi, this pull request allows for environment variables to be used At the environment level, if the environment_variables key is present with a dictionary, it will add it to the update_configuration and create methods. Otherwise, it will send blank data which effectively removes any existing environment variables

The _check_config_md5 method will also consider changes in the yml file, and will update lambda function configuration if any change is detected

I added an example to the kamma-simple project

BrunoCarrier commented 7 years ago

I'm not sure why 8 other commits were bundled in here, since I forked from the main repository lately. Any idea?

josegonzalez commented 7 years ago

You probably branched from master and are pull requesting to develop.

BrunoCarrier commented 7 years ago

Nah they're both from develop - "BrunoCarrier wants to merge 9 commits into garnaat:develop from BrunoCarrier:develop"

BrunoCarrier commented 7 years ago

@josegonzalez @garnaat, is there anything needing to be done so that this is included in the next release? Is there an ETA for the next release?

josegonzalez commented 7 years ago

ETA is whenever someone gets to it. I have a day job that pays bills, open source does not. I'll look at this when I get a chance.

Note: you'll need to figure out how to remove all those extra commits from the pull request.

BrunoCarrier commented 7 years ago

@josegonzalez That sounds good and is absolutely understandable :-) I appreciate the reply

I've fixed the extra commits issue through this other pull request:https://github.com/garnaat/kappa/pull/98

Consequently, I will close this current PR