garnaat / placebo

Make boto3 calls that look real but have no effect.
Apache License 2.0
394 stars 28 forks source link

May not properly name recording files if the file name is a subset of… #62

Closed s-hertel closed 5 years ago

s-hertel commented 7 years ago

… a recording name that already exists

If I have recordings like ec2.DeleteVpnConnectionRoute_1.json and ec2.DeleteVpnConnectionRoute_2.json already recorded then a recording for ec2.DeleteVpnConnection1.json will never be created because the longer ones are matched by the file glob. Fixed by adding '' to the end of the base_name to eliminate longer camel case recording names. Works for my use case but probably needs testing.

garnaat commented 5 years ago

You are correct. The glob pattern was wrong and did not match the regex used elsewhere in the file.