search

garnaat / placebo

Make boto3 calls that look real but have no effect.
Apache License 2.0
394 stars 28 forks source link

Binary body recording #70

Closed I159 closed 3 years ago

I159 commented 6 years ago

During recording a S3 object retrieving request the library raises TypeError while the response is totally valid and changing actual response, thus request couldn't be finished.

kiwiz commented 4 years ago

@garnaat We started hitting this issue too. Could this PR be merged?

garnaat commented 4 years ago

There are some merge conflicts at the moment. If the author wants to resolve those, that would be great. Otherwise I can do it and get it merged.

davidyum commented 4 years ago

+1 just ran into this error too. Would be great if you could merge

TheBishopOfSoho commented 4 years ago

+1 just ran into this error too. Would be great if you could merge

Another +1 to the mix, ran into this while recording a session that pulls a file from S3.

adhorn commented 3 years ago

+1 running into this issue to with AppConfig.

garnaat commented 3 years ago

This should be fixed with a different approach in #79