garnix-io / issues

Public issue tracker for garnix.io
15 stars 0 forks source link

Doesn't detect nixosConfigurations that contain a dot #30

Open NULLx76 opened 1 year ago

NULLx76 commented 1 year ago

Garnix CI doesn't seem to detect nixosConfigurations that contain a ..

output of: nix flake show:

git+file:///home/victor/src/infrastructure?ref=refs%2fheads%2fmain&rev=e614e9ed3b0fb51616b7ce247e8765cfda4af9be
├───colmena: unknown
├───devShells
│   └───x86_64-linux
│       └───default: development environment 'nix-shell'
├───nixosConfigurations
│   ├───"bastion.hades": NixOS configuration
│   ├───"bastion.olympus": NixOS configuration
│   ├───"database.hades": NixOS configuration
│   ├───"database.olympus": NixOS configuration
│   ├───"dhcp.olympus": NixOS configuration
│   ├───"dns-1.olympus": NixOS configuration
│   ├───"dns-2.olympus": NixOS configuration
│   ├───"docker-registry-proxy.hades": NixOS configuration
│   ├───"docker-registry.hades": NixOS configuration
│   ├───"gitea.olympus": NixOS configuration
│   ├───"hedgedoc.olympus": NixOS configuration
│   ├───"jackett2.hades": NixOS configuration
│   ├───"keycloak.olympus": NixOS configuration
│   ├───"mailserver.olympus": NixOS configuration
│   ├───"mastodon.hades": NixOS configuration
│   ├───"minio.hades": NixOS configuration
│   ├───"minio.olympus": NixOS configuration
│   ├───"mosquitto.olympus": NixOS configuration
│   ├───"nginx.olympus": NixOS configuration
│   ├───null: NixOS configuration
│   ├───"outline.olympus": NixOS configuration
│   ├───"prowlarr.hades": NixOS configuration
│   ├───"radarr2.hades": NixOS configuration
│   ├───"rtorrent.hades": NixOS configuration
│   ├───"sonarr2.hades": NixOS configuration
│   ├───"synapse.olympus": NixOS configuration
│   ├───"unifi.hades": NixOS configuration
│   ├───"unifi.olympus": NixOS configuration
│   ├───"vault-0.hades": NixOS configuration
│   ├───"vault-1.olympus": NixOS configuration
│   ├───"vault.olympus": NixOS configuration
│   ├───"victoriametrics.olympus": NixOS configuration
│   └───"wireguard.olympus": NixOS configuration
└───packages
    └───x86_64-linux
        ├───apply-local: package 'apply-local'
        ├───default: package 'colmena-0.4.0-pre'
        └───iso: package 'nixos-22.11.20221009.e3c61a2-x86_64-linux.iso'

But garnix only seems to detect one of them: garnix

Here is a link to an example pipeline: https://github.com/NULLx76/infrastructure/runs/8788941654

jkarni commented 1 year ago

Yeah, I didn't think of dots! Should be a quick fix though. Thanks for the report!

srid commented 1 year ago

Tangential comment: I just wanted to say how much I appreciate the fact that I can even build an entire OS configuration in CI!

sellout commented 7 months ago

Ah, I just got bit by this one. Couldn't figure out why a bunch of my checks weren't being run.

This doesn’t only affect nixosConfigurations, but any output with an attribute name that needs to be quoted.

matrss commented 3 months ago

I just tried out garnix and ran into this issue as well, since I named my nixosConfigurations after the FQDNs of the systems they belong to.

Should be a quick fix though.

Seems like it wasn't :upside_down_face: Any idea when this will get fixed?