search

garrettj403 / SciencePlots

Matplotlib styles for scientific plotting
MIT License
7.12k stars 709 forks source link

Modify installation and exposing of .mplstyles #69

Closed echedey-ls closed 1 year ago

echedey-ls commented 2 years ago

Major changes

Requires updating Wiki and other docs.

Closes #68 Should close #61 too

I'd like as much input as possible. I've been working on it for some time now and done some broad testing, but before breaking anything I'd like someone else to install from my repo and look for any flaws.

Hope this helps.

garrettj403 commented 1 year ago

Hi @echedey-ls

Thanks for putting so much work into this! I always felt that my setup.py file was pretty hacky.

I was able to install from your fork without any issue. Just a couple minor tweaks:

  1. Please change the package name to scienceplots (lower-case). That way we import by import scienceplots and not import SciencePlots.
  2. Please add import scienceplots to the top of plot-examples.py.
echedey-ls commented 1 year ago

Hi, thanks for the feedback. I see I'm a bit late to tell you what I did, haha.

I didn't want to change name (in setup.py) because I think that would mess up the pypi distribution. But as you can see, the rest of SciencePlots have been changed to scienceplots. Tested and it's working on my machine.

As a sidenote, I changed the version bump I did to the current one 1.0.9, so the changelog can be modified at convenience.

Thanks for your work too.